Skip to content

Qualcomm AI Engine Direct - Change transpose output from NCH1 to NC1H before conv - #21707

Open
chenweng-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/chenweng/improve_prefill
Open

Qualcomm AI Engine Direct - Change transpose output from NCH1 to NC1H before conv#21707
chenweng-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/chenweng/improve_prefill

Conversation

@chenweng-quic

@chenweng-quic chenweng-quic commented Aug 10, 2026 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

This memory layout has better performance on the HTP backend, and lead to better performance on prefill model.

Prefill performance of third partitioned graph:

Model w/o w/
llama3.2 3b instruct 55924 35774

cc @cbilgin @psiddh

@pytorch-bot

pytorch-bot Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21707

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit afb0f01 with merge base b20f16a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@chenweng-quic chenweng-quic added the module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ label Aug 10, 2026
@psiddh

psiddh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

cc @digantdesai

@psiddh

psiddh commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@chenweng-quic Can you check the CI failures (and lint-check as well ?) Are they related ?

@chenweng-quic

chenweng-quic commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

checking, will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu abhinaykukkadapu is a code owner
@psiddh psiddh Awaiting requested review from psiddh psiddh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenweng-quic @psiddh